fixed ultof and added tests #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZERICO2005
force-pushed
the
pr/fix_ultof
branch
from
acc64d9 to
4a00adf
Compare
|
ultof should have same rounding as ltof |
|
I have fixed it so it uses round to nearest with ties away from zero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue #466
ultofnow correctly handle values greater thanINT32_MAX. However, ti'sltofwill round to nearest with ties away from zero, whileultofwill round to nearest with ties to even.I am not sure if would be best for
ultofto have the same rounding asltofThanks to calc84maniac for help on
ultof.src